Expose more configuration options as environment variables #1380
+315
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
Dec 19, 2024
msimberg
commented
Dec 19, 2024
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
msimberg
force-pushed
the
config-environment-variables
branch
3 times, most recently
from
2d80e98 to
1c610d9
Compare
…ons via environment variables
It's unused.
…ment variables into account as default
msimberg
force-pushed
the
config-environment-variables
branch
from
1c610d9 to
ee539c8
Compare
msimberg
force-pushed
the
config-environment-variables
branch
from
ee539c8 to
4a5b373
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
msimberg
force-pushed
the
config-environment-variables
branch
from
4a5b373 to
d932bdd
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes:
PIKA_IGNORE_PROCESS_MASKPIKA_THREADSPIKA_SCHEDULERPIKA_BINDas environment variables that can be used to set a default for the corresponding configuration options.
PIKA_SCHEDULERcorresponds topika.schedulerand--pika:queueing.--pika:queuinghas also been renamed to--pika:schedulerhere.Adds tests for the most important variables:
PIKA_THREADS,PIKA_PROCESS_MASK,PIKA_IGNORE_PROCESS_MASK, andPIKA_BIND.The following are also exposed in this PR as environment variables, but I don't intend to document them as I feel like they could be removed any time. They're exposed for development purposes only.
PIKA_AFFINITYPIKA_PU_STEPPIKA_PU_OFFSETPIKA_NUMA_SENSITIVE